Minor refactor of AwsRestService#29
Open
chandu wants to merge 4 commits intorexm:masterfrom
chandu:refactor-transport
Open
Minor refactor of AwsRestService#29chandu wants to merge 4 commits intorexm:masterfrom chandu:refactor-transport
chandu wants to merge 4 commits intorexm:masterfrom
chandu:refactor-transport
Conversation
Owner
|
Thanks Chandu. There's just two issues blocking the merge into master...
Thanks again! |
Owner
|
One other note that isn't a functional issue but makes it easier to collaborate - make sure your IDE is configured to use spaces instead of tabs, and clear out any tab characters Visual Studio might've accidentally inserted. |
Author
|
@rexm Thanks for the feedback.
|
Author
|
Hi @rexm
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed WebRequest and added classes with System.Net.Http for web communication.
Added tests for AwsRestService class.